Android: Display orientation was ignored #774

Merged

SakulFlee merged 12 commits from android-orientation into main

2026-09-06 18:43:10 +02:00

SakulFlee commented

2026-09-06 17:29:22 +02:00

Owner

No description provided.

SakulFlee added the

Context: Bug

label

2026-09-06 17:29:22 +02:00

SakulFlee self-assigned this

2026-09-06 17:29:22 +02:00

SakulFlee added 9 commits

2026-09-06 17:29:22 +02:00

feat(cli): minimal-only init template with procgeo cube on plane 3b1721441f

style: auto-format code 7a57a798b0

Attempting to fix portrait view format on mobile platforms 37bd65a8a5

fix(android): sync camera aspect on resume after rotation 625468f3fb

On Android, device rotation triggers suspended→resumed (native window
destroyed/recreated), not WindowEvent::Resized.  The surface and
renderer were recreated with the new portrait dimensions, but the
camera's CameraDescriptorEcs.aspect stayed at the original 16/9 —
causing a projection mismatch that rendered everything black in portrait.

Sync the camera aspect ratio and WindowSize resource in resumed() to
match the freshly-created surface configuration.

revert(android): undo orientation fixes to restore rotation 854caa07be

Reverts 625468f3 and 37bd65a8 which broke rotation on Android.
The Resized handler and resumed() are back to their original state.
Rotation works again; portrait still shows black (known issue).

fix: handle WiFi ADB serials containing spaces in device list parsing 0f0554f624

The list_devices() parser used split_whitespace().next() to extract the
device serial from 'adb devices' output. WiFi ADB serials like
'adb-d6260ff205bc-htaRwx (3)._adb-tls-connect._tcp' contain spaces,
causing the serial to be truncated and the device to be silently skipped.

Parse the line by scanning for the device state keyword instead, so the
full serial (including spaces) is captured correctly.

fix: recognize tab separator in adb devices output 4c3111b19c

The previous fix checked for a space character before the state keyword,
but adb devices uses a tab character to separate the serial from the
state column. This caused WiFi ADB serials (which contain spaces) to
still be silently skipped.

Use is_ascii_whitespace() instead of == b' ' to handle both tabs and
spaces. Also fix the 'no permissions' branch which had the same issue.

fix(android): change default screen orientation to unspecified 88e17f9da6

Previously defaulted to 'landscape' which locked the activity and
prevented Android from triggering rotation on device tilt.

fix(android): sync camera aspect and depth texture on rotation

CI / lint (pull_request) Failing after 22s

Details

CI / test (pull_request) Has been skipped

Details

22fbaf5b26

Three fixes for portrait rendering after Android rotation:

1. resumed(): Update CameraDescriptorEcs.aspect and WindowSize
   after the surface is recreated with new dimensions, so the
   projection matrix matches the portrait surface.

2. Resized handler: Call renderer.change_resolution() to recreate
   the depth texture at the new surface dimensions, preventing a
   depth-attachment size mismatch that causes the 3D scene to fail
   silently (black clear color remains while overlays still render).

3. Resized handler: Update camera aspect ratio and mark CameraDirty
   so realize_cameras propagates the new aspect to the GPU buffer.

forgejo-actions added 1 commit

2026-09-06 17:29:44 +02:00